Hi Javier,
thank you for the comments,
Am Montag, den 27.08.2012, 10:59 +0200 schrieb javier Martin:
> Hi Philipp,
> thank you for your patch. Please, find some comments below.
>
> On 24 August 2012 18:17, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
[...]
> > @@ -1854,6 +1886,25 @@ static int __devinit coda_probe(struct platform_device *pdev)
> > return -ENOMEM;
> > }
> >
> > + if (dev->devtype->product == CODA_DX6) {
> > + dev->iram_paddr = 0xffff4c00;
> > + } else {
> > + struct device_node *np = pdev->dev.of_node;
> > +
> > + dev->iram_pool = of_get_named_gen_pool(np, "iram", 0);
>
> "of_get_named_gen_pool" doesn't exist in linux_media 'for_v3.7'.
> Moreover, nobody registers an IRAM through the function 'iram_init' in
> mainline [1] so this will never work.
> You will have to wait until this functionality gets merge before
> sending this patch.
>
> > + if (!iram_pool) {
>
> I think you meant 'dev->iram_pool' here, otherwise this will not
> compile properly:
>
> CC drivers/media/video/coda.o
> drivers/media/video/coda.c: In function 'coda_probe':
> drivers/media/video/coda.c:1893: error: implicit declaration of
> function 'of_get_named_gen_pool'
> drivers/media/video/coda.c:1893: warning: assignment makes pointer
> from integer without a cast
> drivers/media/video/coda.c:1894: error: 'iram_pool' undeclared (first
> use in this function)
> drivers/media/video/coda.c:1894: error: (Each undeclared identifier is
> reported only once
> drivers/media/video/coda.c:1894: error: for each function it appears in.)
I was a bit overzealous squashing my patches. For the next round, I'm
using the iram_alloc/iram_free functions that are present in
arch/plat-mxc/include/mach/iram.h (and thus gain a temporary dependency
on ARCH_MXC until there is a mechansim to get to the IRAM gen_pool).
A follow-up patch then would convert the driver to the genalloc API
again.
On a related note, is the 45 KiB VRAM at 0xffff4c00 on i.MX27 reserved
exclusively for the CODA? I suppose rather than hard-coding the address
in the driver, we could use the iram_alloc API on i.MX27, too?
regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
