On Sat, 25 Aug 2012 00:09:06 -0300
Ezequiel Garcia <elezegarcia@xxxxxxxxx> wrote:
> -int vb2_queue_init(struct vb2_queue *q)
> +void vb2_queue_init(struct vb2_queue *q)
> {
> BUG_ON(!q);
> BUG_ON(!q->ops);
If this change goes through in this form, you can add my ack for the
Marvell piece. But I have to wonder...might it not be better to retain
the return value and use it to return -EINVAL instead of the seven BUG_ON()
calls found in that function? It shouldn't be necessary to bring things
down in this situation, and, who knows, one of those might just be turned
into a DOS vector with some driver someday.
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
