Hi Hans, On Wed, Aug 22, 2012 at 10:52:02AM +0200, Hans Verkuil wrote: > On Tue August 21 2012 12:44:15 Sakari Ailus wrote: > > Hi Hans, > > > > On Tue, Aug 21, 2012 at 08:39:53AM +0200, Hans Verkuil wrote: ... > > > Currently I've chosen ioctl numbers that are not used by V4L2 (there are a > > > number of 'holes' in the ioctl list). > > > > > > If people think it is not worth the effort, then so be it. But if we do want > > > to do this, then we can't wait any longer. > > > > One option would be to start using a new type for the new IOCTLs but leave > > the existing ones as they are. The end result would be less elegant since > > the subdev IOCTLs would use two different types but OTOH the V4L2 IOCTLs are > > being used on subdevs as-is, too. This would at least prevent future clashes > > in IOCTL codes between V4L2 and subdev interfaces. > > I don't really like that idea. > > I thought that Laurent's proposal of creating SUBDEV aliases of reused V4L2 > ioctls had merit. That way v4l2-subdev.h would give a nice overview of > which V4L2 ioctls are supported by the subdev API. Currently no such overview > exists to my knowledge. We do --- it's the big switch in v4lw-ioctl.c. If that is to be improved that should be done IMO to the official Linux media infrastructure API spec. > With regards to adding pad fields to the existing control structs: that won't > work with queryctrl: the reserved fields are output fields only, there is no > requirement that apps have to zero them, so you can't use them to enumerate > controls for a particular pad. > > A new queryctrl ioctl would have to be created for that. So if we need this > functionality, then I believe it is better to combine that with a new > queryctrl ioctl. Ack. Cheers, -- Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
