Hi Guennadi,
On Fri, 24 Aug 2012 13:08:52 +0200 (CEST)
Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote:
...
> > +#define MT9V022_HORIZONTAL_BLANKING_MIN 43
> > +#define MT9V022_HORIZONTAL_BLANKING_MAX 1023
> > +#define MT9V022_HORIZONTAL_BLANKING_DEF 94
> > +#define MT9V022_VERTICAL_BLANKING_MIN 2
>
> Interesting, in my datasheet min is 4. Maybe 4 would be a safer bet then.
The legal range in the datasheet here is 2-3000. The datasheet
states that the minimal value must be 4 only if "show dark rows"
control bit is set (it is unset by default).
...
> > +#define V4L2_CID_REG32 (V4L2_CTRL_CLASS_CAMERA | 0x1001)
> > +#define V4L2_CID_ANALOG_CONTROLS (V4L2_CTRL_CLASS_CAMERA | 0x1002)
>
> Sorry, no again. The MT9V022_ANALOG_CONTROL register contains two fields:
> anti-eclipse and "anti-eclipse reference voltage control," don't think
> they should be set as a single control value. IIUC, controls are supposed
> to control logical parameters of the system. In this case you could
> introduce an "anti-eclipse reference voltage" control with values in the
> range between 0 and 2250mV, setting it to anything below 1900mV would turn
> the enable bit off. Would such a control make sense? Then you might want
> to ask on the ML, whether this control would make sense as a generic one,
> not mt9v022 specific.
It probably makes sense since other sensors also have anti-eclipse control
registers.
...
> > if (mt9v022->hdl.error) {
> > int err = mt9v022->hdl.error;
> >
> > + dev_err(&client->dev, "hdl init err %d\n", err);
>
> That's not very clear IMHO. "hdl" isn't too specific, just "control
> initialisation?"
Ok, I'll fix it.
Thanks,
Anatolij
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
