Hi Sakari,
On 08/23/2012 02:13 PM, Sakari Ailus wrote:
> Hi Sylwester,
>
> Thanks for the patch.
Thanks for your review.
> On Thu, Aug 23, 2012 at 11:51:26AM +0200, Sylwester Nawrocki wrote:
>> The V4L2_CID_FRAMESIZE control determines maximum number
>> of media bus samples transmitted within a single data frame.
>> It is useful for determining size of data buffer at the
>> receiver side.
>>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
>> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>> ---
>> Documentation/DocBook/media/v4l/controls.xml | 12 ++++++++++++
>> drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++
>> include/linux/videodev2.h | 1 +
>> 3 files changed, 15 insertions(+)
>>
>> diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml
>> index 93b9c68..ad5d4e5 100644
>> --- a/Documentation/DocBook/media/v4l/controls.xml
>> +++ b/Documentation/DocBook/media/v4l/controls.xml
>> @@ -4184,6 +4184,18 @@ interface and may change in the future.</para>
>> conversion.
>> </entry>
>> </row>
>> + <row>
>> + <entry spanname="id"><constant>V4L2_CID_FRAMESIZE</constant></entry>
>> + <entry>integer</entry>
>> + </row>
>> + <row>
>> + <entry spanname="descr">Maximum size of a data frame in media bus
>> + sample units. This control determines maximum number of samples
>> + transmitted per single compressed data frame. For generic raw
>> + pixel formats the value of this control is undefined. This is
>> + a read-only control.
>> + </entry>
>> + </row>
>> <row><entry></entry></row>
>> </tbody>
>> </tgroup>
>> diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c
>> index b6a2ee7..0043fd2 100644
>> --- a/drivers/media/v4l2-core/v4l2-ctrls.c
>> +++ b/drivers/media/v4l2-core/v4l2-ctrls.c
>> @@ -727,6 +727,7 @@ const char *v4l2_ctrl_get_name(u32 id)
>> case V4L2_CID_VBLANK: return "Vertical Blanking";
>> case V4L2_CID_HBLANK: return "Horizontal Blanking";
>> case V4L2_CID_ANALOGUE_GAIN: return "Analogue Gain";
>> + case V4L2_CID_FRAMESIZE: return "Maximum Frame Size";
>
> I would put this to the image processing class, as the control isn't related
> to image capture. Jpeg encoding (or image compression in general) after all
> is related to image processing rather than capturing it.
All right, might make more sense that way. Let me move it to the image
processing class then. It probably also makes sense to name it
V4L2_CID_FRAME_SIZE, rather than V4L2_CID_FRAMESIZE.
>> /* Image processing controls */
>> case V4L2_CID_IMAGE_PROC_CLASS: return "Image Processing Controls";
>> @@ -933,6 +934,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type,
>> case V4L2_CID_FLASH_STROBE_STATUS:
>> case V4L2_CID_AUTO_FOCUS_STATUS:
>> case V4L2_CID_FLASH_READY:
>> + case V4L2_CID_FRAMESIZE:
>> *flags |= V4L2_CTRL_FLAG_READ_ONLY;
>> break;
>> }
>> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
>> index 7a147c8..d3fd19f 100644
>> --- a/include/linux/videodev2.h
>> +++ b/include/linux/videodev2.h
>> @@ -1985,6 +1985,7 @@ enum v4l2_jpeg_chroma_subsampling {
>> #define V4L2_CID_VBLANK (V4L2_CID_IMAGE_SOURCE_CLASS_BASE + 1)
>> #define V4L2_CID_HBLANK (V4L2_CID_IMAGE_SOURCE_CLASS_BASE + 2)
>> #define V4L2_CID_ANALOGUE_GAIN (V4L2_CID_IMAGE_SOURCE_CLASS_BASE + 3)
>> +#define V4L2_CID_FRAMESIZE (V4L2_CID_IMAGE_SOURCE_CLASS_BASE + 4)
>>
>> /* Image processing controls */
>> #define V4L2_CID_IMAGE_PROC_CLASS_BASE (V4L2_CTRL_CLASS_IMAGE_PROC | 0x900)
--
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
