On 08/17/2012 08:21 PM, CrazyCat wrote:
16.08.2012, 21:11, "Antti Palosaari" <crope@xxxxxx>:
- /* ISDB-T specifics */
- u32 isdbs_ts_id;
-
- /* DVB-T2 specifics */
- u32 dvbt2_plp_id;
+ /* Multistream specifics */
+ u32 stream_id;
u32 == 32 bit long unsigned number. See next comment.
- c->isdbs_ts_id = 0;
- c->dvbt2_plp_id = 0;
+ c->stream_id = -1;
unsigned number cannot be -1. It can be only 0 or bigger. Due to that
this is wrong.
so maybe better declare in as int ? depend from standard valid stream id (for DVB is 0-255) and any another value (-1) disable stream filtering in demod.
I agree that. Actually I was thinking same. For DVB-T2 valid values are
0-255, I haven't looked others but surely int maximum should enough for all.
regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
