Em 16-08-2012 11:29, Antti Palosaari escreveu: > On 08/16/2012 05:07 PM, Hans Verkuil wrote: >> On Thu August 16 2012 15:45:47 Antti Palosaari wrote: >>> On 08/16/2012 03:18 PM, Antti Palosaari wrote: >>>> On 08/16/2012 01:33 PM, Hans Verkuil wrote: >>>>> Building the kernel with the Sensoray 2250/2251 staging go7007 driver >>>>> enabled >>>>> fails with this link error: >>>>> >>>>> ERROR: "usb_cypress_load_firmware" >>>>> [drivers/staging/media/go7007/s2250-loader.ko] undefined! >>>>> >>>>> As far as I can tell this is related to the dvb-usb-v2 changes. >>>>> >>>>> Can someone take a look at this? >>>>> >>>>> Thanks! >>>>> >>>>> Hans >>>> >>>> Yes it is dvb usb v2 related. I wasn't even aware that someone took that >>>> module use in few days after it was added for the dvb-usb-v2. >>>> >>>> Maybe it is worth to make it even more common and move out of dvb-usb-v2... >>>> >>>> regards >>>> Antti >>> >>> And after looking it twice I cannot see the reason. I split that Cypress >>> firmware download to own module called dvb_usb_cypress_firmware which >>> offer routine usbv2_cypress_load_firmware(). Old DVB USB is left >>> untouched. I can confirm it fails to compile for s2250, but there is >>> still old dvb_usb_cxusb that is compiling without a error. >>> >>> Makefile paths seems to be correct also, no idea whats wrong.... >> >> drivers/media/usb/Makefile uses := instead of += for the dvb-usb(-v2) directories, >> and that prevents dvb-usb from being build. I think that's the cause of the link >> error. > > For that I cannot say as I don't understand situation enough. > >> In addition I noticed that in usb/dvb-usb there is a dvb_usb_dvb.c and a >> dvb-usb-dvb.c file: there's a mixup with _ and -. > > These files seems to be my fault. Original patch series removes those, > but I was forced to rebase whole set and in that rebased set those are left unremoved. > Likely due to some rebase conflict. I will send new patch to remove those. If you remove the _, they'll conflict with dvb-usb at media-build.git. The better is to add a _v2 (or -v2) on all dvb-usb-v2 files (or to convert the remaining dvb-usb drivers to dvb-usb-v2). Regards, Mauro > >> Mauro, did that happen during the reorganization? >> >> Regards, >> >> Hans >> > > regards > Antti > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
