Re: [PATCH] [media] iguanair: various fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 11, 2012 at 09:35:29PM -0300, Mauro Carvalho Chehab wrote:
> Em 31-07-2012 07:37, Sean Young escreveu:
> > This fixes:
> >  - rx_overflow while holding down any down button on a nec remote
> >  - suspend/resume
> >  - stop receiver on rmmod
> >  - advertise rx_resolution and timeout properly
> >  - code simplify
> >  - ignore unsupported firmware versions
> 
> Please don't mix several different things on the same patch; it makes
> harder for review and, if any of these changes break, a git revert would
> change a lot of unrelated things. It also makes hard for bug disect.

That makes a lot of sense. I'll rework the patch.

> Tip: "git citool" helps a lot to break messy patches into smaller, concise
> ones.

Thank you very much, I'll try that.


Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux