Em 04-08-2012 05:53, llarevo@xxxxxxx escreveu:
>>>> Wait a minute, unless I completely misunderstood the bug (which is possible),
>>>> I think this patch is straightforward.
>>>>
>>>> By the look of this hunk on commit c2a6b54a:
>>>>
>>>> ---------------------------------8<--------------------------
>>>> diff --git a/drivers/media/video/em28xx/em28xx-core.c
>>>> b/drivers/media/video/em28xx/em28xx-core.c
>>>> index 5b78e19..339fffd 100644
>>>> --- a/drivers/media/video/em28xx/em28xx-core.c
>>>> +++ b/drivers/media/video/em28xx/em28xx-core.c
>>>> @@ -720,7 +720,10 @@ int em28xx_resolution_set(struct em28xx *dev)
>>>> {
>>>> int width, height;
>>>> width = norm_maxw(dev);
>>>> - height = norm_maxh(dev) >> 1;
>>>> + height = norm_maxh(dev);
>>>> +
>>>> + if (!dev->progressive)
>>>> + height >>= norm_maxh(dev);
>>>>
>>>> --------------------------------->8--------------------------
>>>>
>>>> It seems to me that for non-progressive the height should just be
>>>>
>>>> height = height / 2 (or height = height >> 1)
>>>>
>>>> as was before, and as my patch is doing. It seems to driver will
>>>> "merge" the interlaced
>>>> frames and so the "expected" height is half the real height.
>>>> I hope I got it right.
>>>>
>>>> That said and no matter how straightforward may be, which I'm not sure,
>>>> I also want the patch to get tested before being accepted.
>
> I own a Terratec Cinergy XS USB in two flavors: 0ccd:005e and
> 0ccd:0042. I work with Fedora F17. If somebody gives me an advice what
> code to patch (git or a tarball from
> http://linuxtv.org/downloads/drivers/) and what to test, I can make a
> try.
Thanks for your offering, but this should affect only em28xx-based
webcams (like the Silvercrest one).
I have a few here. I'll do the testing.
Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
