On Tue, Aug 7, 2012 at 1:50 AM, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> wrote: > Em 06-08-2012 17:07, Manu Abraham escreveu: >> On Tue, Aug 7, 2012 at 12:32 AM, Mauro Carvalho Chehab >> <mchehab@xxxxxxxxxx> wrote: >>> As noticed at: >>> http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/48034 >>> >>> Both drivers are identical, except for the name. So, there's no >>> sense on keeping both. Instead of forking the entire code, just >>> fork the vp3033_config struct, saving some space, and cleaning >>> up the Kernel. >> >>> >>> Reported-by: Igor M. Liplianin <liplianin@xxxxx> >>> Cc: Manu Abraham <abraham.manu@xxxxxxxxx> >>> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> >> >> Nack. >> >> VP-2033 and 2040 are both different in terms of hardware. If someone >> wants to add >> in additional frontend characteristic differences, he shouldn't have >> to add in this code >> again. > > The code are just the same for both! If it ever become different, then > it could be forked again, but for now, it is just duplicating the same > code on both places and wasting 200 lines of useless code. No, because you see the code that way, it doesn't necessarily mean that you have to merge all code that look similar. That's just peanuts you are talking about. The memory usage appears only if you are using the module. 200 lines of .text is nothing. That exists to differentiate between the 2 devices, not to make both hardware look the same. I have explained why those 2 devices need to be differentiated. Manu -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
