Hi Arun, Please find my comments below. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center > From: Arun Kumar K [mailto:arun.kk@xxxxxxxxxxx] > Sent: 23 July 2012 14:29 > > From: Jeongtae Park <jtp.park@xxxxxxxxxxx> > > Multi Format Codec 6.x is a hardware video coding acceleration > module fount in new Exynos5 SoC series. > It is capable of handling a range of video codecs and this driver > provides a V4L2 interface for video decoding and encoding. > > This is the first patch in the series for MFCv6 support. The major > changes done in this patch is for MFCv5 and MFCv6 co-existence > in the same kernel image. > > Signed-off-by: Jeongtae Park <jtp.park@xxxxxxxxxxx> > Singed-off-by: Janghyuck Kim <janghyuck.kim@xxxxxxxxxxx> > Singed-off-by: Jaeryul Oh <jaeryul.oh@xxxxxxxxxxx> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@xxxxxxxxxxx> > Signed-off-by: Arun Kumar K <arun.kk@xxxxxxxxxxx> > Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > Cc: Kamil Debski <k.debski@xxxxxxxxxxx> > --- > drivers/media/video/Kconfig | 4 +- > drivers/media/video/s5p-mfc/Makefile | 7 +- > drivers/media/video/s5p-mfc/regs-mfc.h | 33 +- > drivers/media/video/s5p-mfc/s5p_mfc.c | 225 +++-- > drivers/media/video/s5p-mfc/s5p_mfc_cmd.c | 98 +-- > drivers/media/video/s5p-mfc/s5p_mfc_cmd.h | 13 + > drivers/media/video/s5p-mfc/s5p_mfc_common.h | 153 +++- > drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c | 198 +++-- > drivers/media/video/s5p-mfc/s5p_mfc_ctrl.h | 1 + > drivers/media/video/s5p-mfc/s5p_mfc_intr.c | 11 +- > drivers/media/video/s5p-mfc/s5p_mfc_opr.c | 1402 +++----------------------- > drivers/media/video/s5p-mfc/s5p_mfc_opr.h | 179 +++-- > drivers/media/video/s5p-mfc/s5p_mfc_pm.c | 8 +- > drivers/media/video/s5p-mfc/s5p_mfc_shm.c | 47 - > drivers/media/video/s5p-mfc/s5p_mfc_shm.h | 90 -- > 15 files changed, 756 insertions(+), 1713 deletions(-) > delete mode 100644 drivers/media/video/s5p-mfc/s5p_mfc_shm.c > delete mode 100644 drivers/media/video/s5p-mfc/s5p_mfc_shm.h > [snip] > diff --git a/drivers/media/video/s5p-mfc/s5p_mfc_cmd.h > b/drivers/media/video/s5p-mfc/s5p_mfc_cmd.h > index 5ceebfe..2be0b64 100644 > --- a/drivers/media/video/s5p-mfc/s5p_mfc_cmd.h > +++ b/drivers/media/video/s5p-mfc/s5p_mfc_cmd.h > @@ -21,10 +21,23 @@ struct s5p_mfc_cmd_args { > unsigned int arg[MAX_H2R_ARG]; After applying all the patches MAX_H2R_ARG is defined in 3 places and I think only the one in s5p_mfc_cmd.h is used. > }; [snip] > diff --git a/drivers/media/video/s5p-mfc/s5p_mfc_opr.c > b/drivers/media/video/s5p-mfc/s5p_mfc_opr.c > index e6217cb..8afda8d 100644 > --- a/drivers/media/video/s5p-mfc/s5p_mfc_opr.c > +++ b/drivers/media/video/s5p-mfc/s5p_mfc_opr.c > @@ -12,1386 +12,276 @@ [snip] > > - s5p_mfc_set_dec_stream_buffer(ctx, 0, 0, 0); > - dev->curr_ctx = ctx->num; > - s5p_mfc_clean_ctx_int_flags(ctx); > - s5p_mfc_decode_one_frame(ctx, MFC_DEC_RES_CHANGE); > +int s5p_mfc_get_warn_start(struct s5p_mfc_dev *dev) > +{ > + return s5p_mfc_ops->s5p_mfc_get_warn_start(dev); > } I think that a callback is not necessary, a simple integer variable should do the job. [snip] -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
