On Sun, Aug 5, 2012 at 2:16 PM, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> wrote: > There's just one driver using fe_ioctl_override(), and it can be > replaced at tuner_attach call. This callback is evil, as only DVBv3 > calls are handled. > > Removing it is also a nice cleanup, as about 90 lines of code are > removed. > > Get rid of it! Did you consult with anyone about this? Did you talk to the maintainer for the driver that uses this functionality (he's not on the CC: for this patch series). Did you actually do any testing to validate that it didn't break anything? This might indeed be a piece of functionality that can possibly be removed, assuming you can answer yes to all three of the questions above. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
