On 08/03/2012 01:31 AM, Malcolm Priestley wrote:
> On Thu, 2012-08-02 at 23:54 +0300, Antti Palosaari wrote:
>> Moi Malcolm,
>> Any idea why this seems to crash Kernel just when device is plugged?
>>
> Hi Antti
>
> Yes, there missing error handling when no firmware file found.
>
> It seems that this is more of a problem with udev-182+.
>
> However, so far udev-182 is only a problem on first ever plug.
>
> Regards
>
>
> Malcolm
>
>
> Signed-off-by: Malcolm Priestley <tvboxspy@xxxxxxxxx>
> ---
> drivers/media/dvb/dvb-usb/lmedm04.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c
> index 25d1031..26ba5bc 100644
> --- a/drivers/media/dvb/dvb-usb/lmedm04.c
> +++ b/drivers/media/dvb/dvb-usb/lmedm04.c
> @@ -878,6 +878,10 @@ static int lme_firmware_switch(struct usb_device *udev, int cold)
> fw_lme = fw_c_rs2000;
> ret = request_firmware(&fw, fw_lme, &udev->dev);
> dvb_usb_lme2510_firmware = TUNER_RS2000;
> + if (ret == 0)
> + break;
> + info("FRM No Firmware Found - please install");
> + cold_fw = 0;
> break;
> default:
> fw_lme = fw_c_s7395;
>
Do we need fw blob anymore!?
http://www.spinics.net/lists/hotplug/msg05257.html
…
"Firmware is loaded natively by udev now, the external 'firmware' binary
is no longer used."
…
Cheers,
poma
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
