Hi Sascha
On Tue, 31 Jul 2012, Sascha Hauer wrote:
> Hi Guennadi,
>
> On Tue, Jul 31, 2012 at 05:14:25PM +0200, Guennadi Liakhovetski wrote:
> > Hi Javier
> >
> > > @@ -436,7 +436,8 @@ static void mx2_camera_deactivate(struct mx2_camera_dev *pcdev)
> > > {
> > > unsigned long flags;
> > >
> > > - clk_disable(pcdev->clk_csi);
> > > + if (cpu_is_mx27())
> > > + clk_disable_unprepare(pcdev->clk_csi);
> >
> > This tells me, there are already 2 things going on here:
> >
> > 1. add clock-(un)prepare operations to enable / disable. Is this a problem
> > atm? is the driver non-functional without this change or is it just an API
> > correctness change? I thought you replied to this already, but
> > unfortunately I couldn't find that your reply again, sorry.
>
> Since the common clock framework clk_prepare is mandatory.
Good, thanks for the clarification. So, this is not a functional, but a
correctness fix. I think, such fixes are acceptable after -rc1 until
something like -rc5, but maybe not after that. So, I'd try to push this
some time within the next couple of weeks, once I get this fix as a
separate patch.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
