On Thu, 26 Jul 2012, Laurent Pinchart wrote: > Hi Sylwester, > > On Tuesday 17 July 2012 20:16:23 Sylwester Nawrocki wrote: > > On 07/16/2012 10:55 AM, Guennadi Liakhovetski wrote: > > > Hi Sylwester > > > > > > Thanks for your comments to my RFC and for pointing out to this your > > > earlier patch series. Unfortunately, I missed in in May, let me try to > > > provide some thoughts about this, we should really try to converge our > > > proposals. Maybe a discussion at KS would help too. > > > > Thank you for the review. I was happy to see your RFC, as previously > > there seemed to be not much interest in DT among the media guys. > > Certainly, we need to work on a common approach to ensure interoperability > > of existing drivers and to avoid having people inventing different > > bindings for common features. I would also expect some share of device > > specific bindings, as diversity of media devices is significant. > > > > I'd be great to discuss these things at KS, especially support for > > proper suspend/resume sequences. Also having common sessions with > > other subsystems folks, like ASoC, for example, might be a good idea. > > > > I'm not sure if I'll be travelling to the KS though. :) > > > > > On Fri, 25 May 2012, Sylwester Nawrocki wrote: > > >> s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC > > >> (camera host interface DMA engine and image processor). This patch > > >> adds support for instantiating the MIPI-CSIS devices from DT and > > >> parsing all SoC and board specific properties from device tree. > > >> The MIPI DPHY control callback is now called directly from within > > >> the driver, the platform code must ensure this callback does the > > >> right thing for each SoC. > > >> > > >> The cell-index property is used to ensure proper signal routing, > > >> from physical camera port, through MIPI-CSI2 receiver to the DMA > > >> engine (FIMC?). It's also helpful in exposing the device topology > > >> in user space at /dev/media? devnode (Media Controller API). > > >> > > >> This patch also defines a common property ("data-lanes") for MIPI-CSI > > >> receivers and transmitters. > > >> > > >> Signed-off-by: Sylwester Nawrocki<s.nawrocki@xxxxxxxxxxx> > > >> Signed-off-by: Kyungmin Park<kyungmin.park@xxxxxxxxxxx> > > >> --- > > >> > > >> Documentation/devicetree/bindings/video/mipi.txt | 5 + > > >> .../bindings/video/samsung-mipi-csis.txt | 47 ++++++++++ > > >> drivers/media/video/s5p-fimc/mipi-csis.c | 97 > > >> +++++++++++++++----- drivers/media/video/s5p-fimc/mipi-csis.h > > >> | 1 + > > >> 4 files changed, 126 insertions(+), 24 deletions(-) > > >> create mode 100644 Documentation/devicetree/bindings/video/mipi.txt > > >> create mode 100644 > > >> Documentation/devicetree/bindings/video/samsung-mipi-csis.txt>> > > >> diff --git a/Documentation/devicetree/bindings/video/mipi.txt > > >> b/Documentation/devicetree/bindings/video/mipi.txt new file mode 100644 > > >> index 0000000..5aed285 > > >> --- /dev/null > > >> +++ b/Documentation/devicetree/bindings/video/mipi.txt > > >> @@ -0,0 +1,5 @@ > > >> +Common properties of MIPI-CSI1 and MIPI-CSI2 receivers and transmitters > > >> + > > >> + - data-lanes : number of differential data lanes wired and actively > > >> used in > > >> + communication between the transmitter and the receiver, this > > >> + excludes the clock lane; > > > > > > Wouldn't it be better to use the standard "bus-width" DT property? > > > > I can't see any problems with using "bus-width". It seems sufficient > > and could indeed be better, without a need to invent new MIPI-CSI > > specific names. That was my first RFC on that and my perspective > > wasn't probably broad enough. :) > > What about CSI receivers that can reroute the lanes internally ? We would need > to specify lane indices for each lane then, maybe with something like > > clock-lane = <0>; "clock-lanes" for uniformity? > data-lanes = <2 3 1>; Are there transmitters, that can reroute lanes too? Thanks Guennadi > For receivers that can't reroute lanes internally, the data-lanes property > would be need to specify lanes in sequence. > > data-lanes = <1 2 3>; > > -- > Regards, > > Laurent Pinchart > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html