On Fri, 2012-07-27 at 09:45 -0600, Tim Gardner wrote: > On 07/26/2012 04:21 PM, Andy Walls wrote: > > On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote: > >> Cc: Andy Walls <awalls@xxxxxxxxxxxxxxxx> > >> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> > >> Cc: ivtv-devel@xxxxxxxxxxxxxx > >> Cc: linux-media@xxxxxxxxxxxxxxx > >> Signed-off-by: Tim Gardner <tim.gardner@xxxxxxxxxxxxx> > >> --- > >> drivers/media/video/ivtv/ivtv-firmware.c | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c > >> index 02c5ade..6ec7705 100644 > >> --- a/drivers/media/video/ivtv/ivtv-firmware.c > >> +++ b/drivers/media/video/ivtv/ivtv-firmware.c > >> @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where) > >> > >> return res; > >> } > >> + > >> +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME); > >> +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME); > >> +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME); > > > > Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the > > CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME. (And even > > in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME > > file is non-fatal.) > > > > I would not want anything in user-space or kernel space preventing the > > ivtv module from loading, if some of those files don't exist. > > > > Regards, > > Andy > > > > MODULE_FIRMWARE is informational only and has no runtime impact. OK. Acked-by: Andy Walls <awalls@xxxxxxxxxxxxxxxx> Regards, Andy > > rtg -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
