Hi Laurent, Thanks for the patch. On Tue, Jul 24, 2012 at 01:10:42AM +0200, Laurent Pinchart wrote: > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/media/video/mt9v032.c | 36 +++++++++++++++++++++++++++++++++--- > 1 files changed, 33 insertions(+), 3 deletions(-) > > Changes since v1: > > - Make sure the total horizontal time will not go below 660 when setting the > horizontal blanking control > - Restrict the vertical blanking value to 3000 as documented in the datasheet. > Increasing the exposure time actually extends vertical blanking, as long as > the user doesn't forget to turn auto-exposure off... Does binning either horizontally or vertically affect the blanking limits? If the process is analogue then the answer is typically "yes". It's not directly related to this patch, but the effect of the driver just exposing one sub-device really shows better now. Besides lacking the way to specify binning as in the V4L2 subdev API (compose selection target), the user also can't use the crop bounds selection target to get the size of the pixel array. We could either accept this for the time being and fix it later on of fix it now. I prefer fixing it right now but admit that this patch isn't breaking anything, it rather is missing quite relevant functionality to control the sensor in a generic way. Kind regards, -- Sakari Ailus e-mail: sakari.ailus@xxxxxx jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
