Hi Laurent,
On 07/26/2012 04:42 PM, Laurent Pinchart wrote:
Hi Sylwester,
On Friday 25 May 2012 21:52:40 Sylwester Nawrocki wrote:
For systems instantiated from device tree struct platform_device id
field is always -1, add an 'id' argument to the s5p_csis_phy_enable()
function so the MIPI-CSIS hardware instance index can be passed in
by driver, for CONFIG_OF=y.
Signed-off-by: Sylwester Nawrocki<s.nawrocki@xxxxxxxxxxx>
Signed-off-by: Kyungmin Park<kyungmin.park@xxxxxxxxxxx>
---
arch/arm/plat-s5p/setup-mipiphy.c | 20 ++++++++------------
arch/arm/plat-samsung/include/plat/mipi_csis.h | 10 ++++++----
2 files changed, 14 insertions(+), 16 deletions(-)
diff --git a/arch/arm/plat-s5p/setup-mipiphy.c
b/arch/arm/plat-s5p/setup-mipiphy.c index 683c466..146ecc3 100644
--- a/arch/arm/plat-s5p/setup-mipiphy.c
+++ b/arch/arm/plat-s5p/setup-mipiphy.c
@@ -14,24 +14,19 @@
#include<linux/spinlock.h>
#include<mach/regs-clock.h>
-static int __s5p_mipi_phy_control(struct platform_device *pdev,
+static int __s5p_mipi_phy_control(struct platform_device *pdev, int id,
bool on, u32 reset)
What about removing the pdev argument, as it's now not needed ?
Indeed, it isn't useful any more. I'm not sure what I intended to
keep it for, perhaps just some sentimental reasons.. :)
Thanks for pointing out, I'll remove it in the next iteration.
--
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html