Hi Prabhakar, Thanks for the patch! Just a few comments. On Fri, Jul 20, 2012 at 08:28:09PM +0530, Prabhakar Lad wrote: > From: Manjunath Hadli <manjunath.hadli@xxxxxx> > > add new enum entries for supporting the media-bus formats on dm365. > These include some bayer and some non-bayer formats. > V4L2_MBUS_FMT_YDYUYDYV8_1X16 and V4L2_MBUS_FMT_UV8_1X8 are used > internal to the hardware by the resizer. > V4L2_MBUS_FMT_SBGGR10_ALAW8_1X8 represents the bayer ALAW format > that is supported by dm365 hardware. > > Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > Signed-off-by: Manjunath Hadli <manjunath.hadli@xxxxxx> > Signed-off-by: Lad, Prabhakar <prabhakar.lad@xxxxxx> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Cc: Sakari Ailus <sakari.ailus@xxxxxx> > Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > --- > Documentation/DocBook/media/v4l/subdev-formats.xml | 250 +++++++++++++++++++- > include/linux/v4l2-mediabus.h | 10 +- > 2 files changed, 252 insertions(+), 8 deletions(-) > > diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml > index 49c532e..01b2811 100644 > --- a/Documentation/DocBook/media/v4l/subdev-formats.xml > +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml ... > @@ -853,10 +921,16 @@ > <title>Packed YUV Formats</title> > > <para>Those data formats transfer pixel data as (possibly downsampled) Y, U > - and V components. The format code is made of the following information. > + and V components. Some formats include dummy bits in some of their samples > + and are collectively referred to as "YDYC" (Y-Dummy-Y-Chroma) formats. > + One cannot rely on the values of these dummy bits as those are undefined. > + </para> > + <para>The format code is made of the following information. Also many raw bayer formats contain padding bits to align pixels to byte boundaries. We haven't had a situation where we'd have the same amount of information per pixel on a pixel format with and without padding. The definition of those formats does not require the padding bits to be zero, but in practice they always are. How about the dm series of chips; are the bits always zero? The OMAP 3 ISP spec doesn't specify that either AFAIR but in practice the ISP only writes zeros there. ... > @@ -877,7 +951,21 @@ > U, Y, V, Y order will be named <constant>V4L2_MBUS_FMT_UYVY8_2X8</constant>. > </para> > > - <para>The following table lisst existing packet YUV formats.</para> > + <para><xref linkend="v4l2-mbus-pixelcode-yuv8"/> list existing packet YUV s/list/lists/ ? Kind regards, -- Sakari Ailus e-mail: sakari.ailus@xxxxxx jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
