On Wed, Jul 18, 2012 at 7:26 PM, Ismael Luceno <ismael.luceno@xxxxxxxxx> wrote: > On Thu, Jun 21, 2012 at 4:52 PM, Ezequiel Garcia <elezegarcia@xxxxxxxxx> wrote: >> This patch moves video_nr module parameter to core.c >> and then passes that parameter as an argument to functions >> that need it. >> This way we avoid the extern declaration and parameter >> dependencies are better exposed. > <...> > > NACK. > > The changes to video_nr are supposed to be preserved. Mmm, I'm sorry but I don't see any functionality change in this patch, just a cleanup. What do you mean by "changes to video_nr are supposed to be preserved"? -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html