Hi Guennadi, On 07/18/2012 09:57 AM, Guennadi Liakhovetski wrote: > On Tue, 17 Jul 2012, Sylwester Nawrocki wrote: >> On 07/16/2012 11:15 AM, Guennadi Liakhovetski wrote: >>>> --- a/Documentation/devicetree/bindings/camera/soc/samsung-fimc.txt >>>> +++ b/Documentation/devicetree/bindings/camera/soc/samsung-fimc.txt >>>> @@ -39,6 +39,21 @@ Required properties: >>>> depends on the SoC revision. For S5PV210 valid values are: >>>> 0...2, for Exynos4x1x: 0...3. >>>> >>>> + >>>> +'fimc-lite' device node >>>> +----------------------- >>>> + >>>> +Required properties: >>>> + >>>> +- compatible : should be one of: >>>> + "samsung,exynos4212-fimc"; >>>> + "samsung,exynos4412-fimc"; >>>> +- reg : physical base address and size of the device's memory >>>> mapped >>>> + registers; >>>> +- interrupts : should contain FIMC-LITE interrupt; >>>> +- cell-index : FIMC-LITE IP instance index; >>> >>> Same as in an earlier patch - not sure this is needed. >> >> It is needed for setting up a pipeline of multiple sub-device >> within a SoC. As I commented on patch 2/13 I'd like to replace >> this with proper entries in the "aliases" node. Some sub-devices >> have registers that these indexes need to be directly written to. > > Aha, so, these are not purely software indices, that you just use to > identify your devices, these are actual hardware values? You really have > to write, e.g., "1" into a resizer register to connect it to a certain > capture engine? Ok, in this case it indeed might make sense to have these Yes, that's more or less how it works. If I select input mux id = 0, then MIPI-CSIS0 have to be used for streaming. For this FIMC-LITE device there are some commands/registers within the device that sits after FIMC-LITE in the data pipeline (not yet mainlined). > values in the DT. Not sure how best to call these properties, or whether > aliases is the best solution, but that's already a detail. And btw, if you Yeah, the property seems more accurate. But I don't really mind, I could just use whatever is accepted in the mainline. > do decide to keep this as a property, maybe this is one of the cases, > where you'd want to mark it with your hardware type, like "fimc,cell-id" > or similar? I'm not sure about that. "cell-index" has well defined semantics. So there should be no reason to use device specific property. I would have then to use "samsung,fimc-cell-id", "samsung,fimc-lite-cell-id" and "samsung,csis-cell-id", as all device specific bindings need to be prefixed with a manufacturer code. -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
