On Wed 18 July 2012 14:42:00 javier Martin wrote: > Hi Hans, > thank you for your review. > > On 18 July 2012 13:00, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: <snip> > > > > Colorspace. > > But I don't know how to handle colorspace in this driver. Video > encoder from samsung > (http://lxr.linux.no/#linux+v3.4.5/drivers/media/video/s5p-mfc/s5p_mfc_enc.c#L844 > ) does not handle it either. That's wrong too :-) > This is a video encoder which gets an input video streaming (with its > specific colorspace) and encodes it. I understand the sense of this > field for a video source but for an encoder? An encoder should copy the colorspace of the video it receives to the output video format and default to V4L2_COLORSPACE_SMPTE170M (SDTV) or V4L2_COLORSPACE_REC709 (HDTV). So as long as userspace hasn't told the driver what the colorspace is of the video it will encode you can return a default colorspace. Once you know the actual colorspace, then that's what should be returned. This assumes that the encoder doesn't do any colorspace changes and just encodes as is. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
