Re: [PATCH 1/7] media: mmp_camera: Add V4l2 camera driver for Marvell PXA910/PXA688/PXA2128 CCIC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 14 Jul 2012, Jonathan Corbet wrote:

> On Wed, 11 Jul 2012 22:22:29 +0800
> Albert Wang <twang13@xxxxxxxxxxx> wrote:
> 
> > This v4l2 camera driver is based on soc-camera and videobuf2 framework
> > Support Marvell MMP Soc family TD-PXA910/MMP2-PXA688/MMP3-PXA2128 CCIC
> > Support Dual CCIC controllers on PXA688/PXA2128
> > Support MIPI-CSI2 mode and DVP-Parallel mode
> 
> This is going to be really quick.  Life is difficult here, I don't really
> have much time to put into anything.
> 
> >  arch/arm/mach-mmp/include/mach/camera.h    |   21 +
> 
> I don't think that this file belongs here; it should be in the driver
> tree.  This camera may not always be tied to this platform; indeed, the
> original Cafe was not.  There will never be a 64-bit SoC with some variant
> of this device?
> 
> >  
> > +config VIDEO_MMP
> > +	tristate "Marvell MMP CCIC driver based on SOC_CAMERA"
> > +	depends on VIDEO_DEV && SOC_CAMERA
> > +	select VIDEOBUF2_DMA_CONTIG
> > +	---help---
> > +	  This is a v4l2 driver for the Marvell PXA910/PXA688/PXA2128 CCIC
> > +	  To compile this driver as a module, choose M here: the module will
> > +	  be called mmp_camera.
> 
> But...the existing driver already builds as mmp_camera.  Even if we
> eventually agree that this separate driver should go into the mainline, it
> really needs to not build into a module with the same name.

So far my opinion is, that this driver should really be re-using code from 
marvell-ccic. Someone really has to convince me, that this is impossible 
and this driver should go into the kernel independently.

Thanks
Guennadi

> > +/*
> > + * V4L2 Driver for Marvell Mobile SoC PXA910/PXA688/PXA2128 CCIC
> > + * (CMOS Camera Interface Controller)
> > + *
> > + * This driver is based on soc_camera and videobuf2 framework,
> > + * but part of the low level register function is base on cafe-driver.c
> > + *
> > + * Copyright 2006 One Laptop Per Child Association, Inc.
> > + * Copyright 2006-7 Jonathan Corbet <corbet@xxxxxxx>
> 
> Nit: some of the code clearly comes from marvell-ccic/mcam-core.c, so the
> copyright dates (if they really need to be kept) should stretch into 2011
> or so.
> 
> I don't see anything else obvious, but it was a very quick reading, sorry.
> 
> jon

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux