Hi Sakari,
On Friday 13 July 2012 12:51:36 Sakari Ailus wrote:
> Laurent Pinchart wrote:
> ...
>
> > @@ -817,7 +817,7 @@ static const struct preview_update update_attrs[] = {
> > offsetof(struct omap3isp_prev_update_config, dcor),
> > }, /* OMAP3ISP_PREV_GAMMABYPASS */ {
> > NULL,
> > - preview_enable_gammabypass,
> > + NULL,
> > }, /* OMAP3ISP_PREV_DRK_FRM_CAPTURE */ {
> > NULL,
> > preview_enable_drkframe_capture,
> > @@ -835,7 +835,7 @@ static const struct preview_update update_attrs[] = {
> > offsetof(struct omap3isp_prev_update_config, nf),
> > }, /* OMAP3ISP_PREV_GAMMA */ {
> > preview_config_gammacorrn,
> > - NULL,
> > + preview_enable_gammacorrn,
> > offsetof(struct prev_params, gamma),
> > FIELD_SIZEOF(struct prev_params, gamma),
> > offsetof(struct omap3isp_prev_update_config, gamma),
>
> Doesn't this change the behaviour of the user space API?
That's correct, it does.
> I'm not sure if we _really_ need to worry about that _too_ much, but I
> think that if OMAP3ISP_PREV_GAMMABYPASS is no longer used anywhere the
> definition should be removed as well to prevent anyone accidentally from
> using it.
Good point. I'll replace it with a comment that warns not to use bit 11.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
