Hi Ismael, On Thu, Jun 21, 2012 at 4:53 PM, Ezequiel Garcia <elezegarcia@xxxxxxxxx> wrote: > Hi Mauro, > > This patchset aims at cleaning most issues reported by ./scripts/checkpatch.pl. > I'm not sure if all of them are useful, so if you feel any of the > patches are too dumb just drop it. > > I'm Ccing the author Ben Collins, dispite he's no longer working for > the device manufacturer Bluecherry. > > The patches are based on today's linux-next; I hope this is okey. > As I don't own this device, I can't provide any test beyond compilation. > > Ezequiel Garcia (10): > staging: solo6x10: Avoid extern declaration by reworking module parameter > staging: solo6x10: Fix several over 80 character lines > staging: solo6x10: Declare static const array properly > staging: solo6x10: Merge quoted string split across lines > staging: solo6x10: Replace printk(KERN_WARNING with dev_warn > staging: solo6x10: Remove format type mismatch warning > staging: solo6x10: Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id > staging: solo6x10: Replace C++ style comment with C style > staging: solo6x10: Use linux/{io,uaccess}.h instead of asm/{io,uaccess}.h > staging: solo6x10: Fix TODO file with proper maintainer > > drivers/staging/media/solo6x10/TODO | 2 +- > drivers/staging/media/solo6x10/core.c | 14 ++++++--- > drivers/staging/media/solo6x10/gpio.c | 2 +- > drivers/staging/media/solo6x10/i2c.c | 3 +- > drivers/staging/media/solo6x10/p2m.c | 8 +++--- > drivers/staging/media/solo6x10/solo6x10.h | 6 ++-- > drivers/staging/media/solo6x10/tw28.c | 6 ++-- > drivers/staging/media/solo6x10/v4l2-enc.c | 39 ++++++++++++++--------------- > drivers/staging/media/solo6x10/v4l2.c | 25 +++++++++--------- > 9 files changed, 54 insertions(+), 51 deletions(-) > > Regards, > Ezequiel. I'm sending you this patch set because I saw on bluecherry blog that you're working there, replacing Ben Collins (author of solo6x10). Please correct me if I'm wrong. I wonder if you could review this series, test, ack or even nack them :-) They are mostly style fixes, so there shouldn't be any problems. Thanks, Ezequiel. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html