On Fri, Jul 06, 2012 at 09:46:46AM +0200, javier Martin wrote:
> On 6 July 2012 09:34, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
> > On Fri, Jul 06, 2012 at 09:13:11AM +0200, Javier Martin wrote:
> >> if (cpu_is_mx27()) {
> >> free_irq(pcdev->irq_emma, pcdev);
> >> - clk_disable(pcdev->clk_emma);
> >> - clk_put(pcdev->clk_emma);
> >> + clk_disable_unprepare(pcdev->clk_emma_ipg);
> >> + clk_disable_unprepare(pcdev->clk_emma_ahb);
> >
> > The clk_disable_unprepare is inside a cpu_is_mx27() which seems correct.
> > Shouldn't the corresponding clk_get be in cpu_is_mx27() aswell?
>
> Yes indeed. Should I fix it in a new version of this patch or should I
> send another one instead?
Another version of this patch should be fine.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
