Hi Ralph, > are you sure about this? > From what I have been told, the 2 parameter command is in the > firmware ROM and older loadable/patch firmwares. > Newer firmwares provided the 4 parameter command. The firmwares in the ROM are a good point. I discussed with Mauro Carvalho Chehab before I started writing my patch, and he told me that the only (loadable) firmware that uses the old command is the "drxk_a3.mc" one. But you are right, there is some firmware (for DVB-C, afaik it's NOT for DVB-T) stored in the ROM. If I find out that the ROM uses the "old" command then I'll probably try making this smart: old_qam_demod_cmd will be an int with the following possible values: * -1: unknown - trial and error approach will be used (afterwards this will be updated to either 0 or 1) * 0: use the 2-parameter command * 1: use the 4-parameter command I'll also try to guess a smart default value: -1 will be used if no firmware was given. Otherwise 0 will be the default. The remaining two drxk_config instances that are still using the old firmware will be set to 1 (like in my first patch). If everything goes right then I'll be able to test and update my patch tonight. Regards, Martin -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
