Hi Hans, On Wednesday 27 June 2012 12:38:54 Hans Verkuil wrote: > On Wed 27 June 2012 11:54:40 Laurent Pinchart wrote: > > On Friday 22 June 2012 14:21:13 Hans Verkuil wrote: > > > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > > > > > Since this could theoretically change the debug value while in the > > > middle of v4l2-ioctl.c, we make a copy of vfd->debug to ensure > > > consistent debug behavior. > > > > In my review of RFCv1, I wrote that this could introduce a race condition: > > > > "You test the debug value several times in the __video_do_ioctl() > > function. I haven't checked in details whether changing the value between > > the two tests could for instance lead to a KERN_CONT print without a > > previous non-KERN_CONT message. That won't crash the machine but it > > should still be avoided." > > > > Have you verified whether that problem can occur ? > > Yes, this problem can occur. Which is why I've changed the code accordingly. I've missed that. My bad, sorry. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
