On Wed 27 June 2012 11:42:31 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 22 June 2012 14:21:21 Hans Verkuil wrote: > > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > > > Add helper functions to make it easier to adapt drivers to vb2. > > > > These helpers take care of core locking and check if the filehandle is the > > owner of the queue. > > > > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > --- > > drivers/media/video/videobuf2-core.c | 227 +++++++++++++++++++++++++++++++ > > Was it not possible to move the functions to videobuf2-ioctl.c ? Yes, it was possible, but it would require making some functions extern instead of static. In my opinion there is not enough advantage in moving these functions to a separate file. I've added additional comments that should prevent any confusion. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
