Em 26-06-2012 17:44, Greg KH escreveu: > On Tue, Jun 26, 2012 at 04:34:22PM -0300, Mauro Carvalho Chehab wrote: >> When tuner-xc2028 is not compiled as a module, dracut will >> need to copy the firmware inside the initfs image. >> >> So, use MODULE_FIRMWARE() to indicate such need. >> >> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> >> --- >> drivers/media/common/tuners/tuner-xc2028.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/media/common/tuners/tuner-xc2028.c b/drivers/media/common/tuners/tuner-xc2028.c >> index b5ee3eb..2e6c966 100644 >> --- a/drivers/media/common/tuners/tuner-xc2028.c >> +++ b/drivers/media/common/tuners/tuner-xc2028.c >> @@ -1375,3 +1375,5 @@ MODULE_DESCRIPTION("Xceive xc2028/xc3028 tuner driver"); >> MODULE_AUTHOR("Michel Ludwig <michel.ludwig@xxxxxxxxx>"); >> MODULE_AUTHOR("Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>"); >> MODULE_LICENSE("GPL"); >> +MODULE_FIRMWARE(XC2028_DEFAULT_FIRMWARE); >> +MODULE_FIRMWARE(XC3028L_DEFAULT_FIRMWARE); > > This is proabably something that needs to get in now, independant of the > other 3 patches, right? Yes, this one is independent. This were not added before as the firmware names are/used to be device-specific, and there's a modprobe parameter that allows overriding it. Currently, all xc3028 devices since a long time uses version 2.7, and all XC3028L uses version 3.2. (I still have here a device that only works with a custom v 1.f firmware). Anyway, it makes sense to at least use the two most common possible firmwares there. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html