Re: [PATCH RFC 2/4] em28xx: defer probe() if userspace mode is disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 26, 2012 at 04:34:20PM -0300, Mauro Carvalho Chehab wrote:
> +	/*
> +	 * If the device requires firmware, probe() may need to be
> +	 * postponed, as udev may not be ready yet to honour firmware
> +	 * load requests.
> +	 */
> +	if (em28xx_boards[id->driver_info].needs_firmware &&
> +	    is_usermodehelp_disabled()) {
> +		printk_once(KERN_DEBUG DRIVER_NAME
> +		            ": probe deferred for board %d.\n",
> +		            (unsigned)id->driver_info);
> +		return -EPROBE_DEFER;

You should printk once per device, right?  Not just for one time per
module load.

Also, what about using dev_dbg()?  Is there a _once version that works
for that?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux