Re: Recent patch for videobuf causing a crash to my driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

On Fri, Jun 22, 2012 at 2:58 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
> On Fri June 22 2012 11:11:36 Prabhakar Lad wrote:
>> Hi Hans,
>>
>> On Fri, Jun 22, 2012 at 2:29 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
>> > On Fri June 22 2012 10:50:23 Laurent Pinchart wrote:
>> >> Hi Hans,
>> >>
>> >> On Friday 22 June 2012 09:50:44 Hans Verkuil wrote:
>> >> > On 22/06/12 05:39, Prabhakar Lad wrote:
>> >> > > Hi Federico,
>> >> > >
>> >> > > Recent patch from you (commit id a8f3c203e19b702fa5e8e83a9b6fb3c5a6d1cce4)
>> >> > > which added cached buffer support to videobuf dma contig, is causing my
>> >> > > driver to crash.
>> >> > > Has this patch being tested for 'uncached' buffers ? If I replace this
>> >> > > mapping logic with remap_pfn_range() my driver works without any crash.
>> >> > >
>> >> > > Or is that I am missing somewhere ?
>> >> >
>> >> > No, I had the same problem this week with vpif_capture. Since I was running
>> >> > an unusual setup (a 3.0 kernel with the media subsystem patched to 3.5-rc1)
>> >> > I didn't know whether it was caused by a mismatch between 3.0 and a 3.5
>> >> > media subsystem.
>> >> >
>> >> > I intended to investigate this next week, but now it is clear that it is
>> >> > this patch that is causing the problem.
>> >>
>> >> Time to port the driver to videobuf2 ? ;-)
>> >>
>> >>
>> >
>> > That's actually something on my todo list...
>>
>>  In fact I have ported VPIF to videobuf2, It works fine with MMAP based
>> buffers, Its crashing for USERPTR buffers. still need to fix it :(
>
> Can you post it? I'd like to take a look myself.

  Ok, I will clean it up and post it soon.

Thx,
--Prabhakar Lad

>
> Regards,
>
>        Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux