Hi Laurent
Thanks for the patch
On Wed, 23 May 2012, Laurent Pinchart wrote:
> The g_mbus_fmt operation only needs to return the current mbus frame
> format and doesn't need to configure the hardware to do so. Fix it to
> avoid requiring the chip to be powered on when calling the operation.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/video/ov2640.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/video/ov2640.c b/drivers/media/video/ov2640.c
> index 3c2c5d3..d9a427c 100644
> --- a/drivers/media/video/ov2640.c
> +++ b/drivers/media/video/ov2640.c
> @@ -837,10 +837,7 @@ static int ov2640_g_fmt(struct v4l2_subdev *sd,
>
> if (!priv->win) {
> u32 width = W_SVGA, height = H_SVGA;
> - int ret = ov2640_set_params(client, &width, &height,
> - V4L2_MBUS_FMT_UYVY8_2X8);
> - if (ret < 0)
> - return ret;
> + priv->win = ov2640_select_win(&width, &height);
I think you also have to set
priv->cfmt_code = V4L2_MBUS_FMT_UYVY8_2X8;
Thanks
Guennadi
> }
>
> mf->width = priv->win->width;
> --
> 1.7.3.4
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
