Em 08-06-2012 21:50, Akinobu Mita escreveu: > Use memweight() to count the total number of bits set in memory area. > > Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx Acked-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > --- > No changes from v1 > > drivers/media/video/uvc/uvc_ctrl.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/video/uvc/uvc_ctrl.c b/drivers/media/video/uvc/uvc_ctrl.c > index af26bbe..f7061a5 100644 > --- a/drivers/media/video/uvc/uvc_ctrl.c > +++ b/drivers/media/video/uvc/uvc_ctrl.c > @@ -2083,7 +2083,7 @@ int uvc_ctrl_init_device(struct uvc_device *dev) > /* Walk the entities list and instantiate controls */ > list_for_each_entry(entity, &dev->entities, list) { > struct uvc_control *ctrl; > - unsigned int bControlSize = 0, ncontrols = 0; > + unsigned int bControlSize = 0, ncontrols; > __u8 *bmControls = NULL; > > if (UVC_ENTITY_TYPE(entity) == UVC_VC_EXTENSION_UNIT) { > @@ -2101,8 +2101,7 @@ int uvc_ctrl_init_device(struct uvc_device *dev) > uvc_ctrl_prune_entity(dev, entity); > > /* Count supported controls and allocate the controls array */ > - for (i = 0; i < bControlSize; ++i) > - ncontrols += hweight8(bmControls[i]); > + ncontrols = memweight(bmControls, bControlSize); > if (ncontrols == 0) > continue; > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html