Re: [RFCv1 PATCH 30/32] v4l2-ioctl.c: shorten the lines of the table.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

On Monday 18 June 2012 13:34:33 Hans Verkuil wrote:
> On Mon June 18 2012 11:57:24 Laurent Pinchart wrote:
> > On Sunday 10 June 2012 12:25:52 Hans Verkuil wrote:
> > > From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> > > 
> > > Use some macro magic to reduce the length of the lines in the table.
> > > This makes it more readable.
> > 
> > It indeed shortens the lines, but to be honest I find the result less
> > readable.
> 
> What do you think, should I just keep those long lines?

I think that's better. If several fields could be computed from the same 
information in all cases then I'd be fine with specifying the common 
information only, but just shortening names makes the code less readable in my 
opinion. 

> I've tried splitting them up, but that too made it harder to read.

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux