Em 18-06-2012 06:46, Laurent Pinchart escreveu:
> Hi Hans,
>
> Thanks for the patch.
>
> On Sunday 10 June 2012 12:25:40 Hans Verkuil wrote:
>> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>>
>> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>> ---
>> drivers/media/video/v4l2-ioctl.c | 35 +++++++++++++----------------------
>> 1 file changed, 13 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/media/video/v4l2-ioctl.c
>> b/drivers/media/video/v4l2-ioctl.c index 0de31c4..6c91674 100644
>> --- a/drivers/media/video/v4l2-ioctl.c
>> +++ b/drivers/media/video/v4l2-ioctl.c
>> @@ -870,6 +870,11 @@ static void v4l_print_newline(const void *arg)
>> pr_cont("\n");
>> }
>>
>> +static void v4l_print_default(const void *arg)
>> +{
>> + pr_cont("non-standard ioctl\n");
>
> I'd say "driver-specific ioctl" instead. "non-standard" may sound like an
> error to users.
This message is useless as-is, as it provides no glue about what ioctl was
called. You should either remove it or print the ioctl number, in hexa.
Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
