Re: [RFCv1 PATCH 25/32] create_bufs: handle count == 0.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

Thanks for the patch.

On Sunday 10 June 2012 12:25:47 Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> 
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> ---
>  Documentation/DocBook/media/v4l/vidioc-create-bufs.xml |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/DocBook/media/v4l/vidioc-create-bufs.xml
> b/Documentation/DocBook/media/v4l/vidioc-create-bufs.xml index
> 765549f..afdba4d 100644
> --- a/Documentation/DocBook/media/v4l/vidioc-create-bufs.xml
> +++ b/Documentation/DocBook/media/v4l/vidioc-create-bufs.xml
> @@ -97,7 +97,13 @@ information.</para>
>  	  <row>
>  	    <entry>__u32</entry>
>  	    <entry><structfield>count</structfield></entry>
> -	    <entry>The number of buffers requested or granted.</entry>
> +	    <entry>The number of buffers requested or granted. If count == 0,
> then
> +	    <constant>VIDIOC_CREATE_BUFS</constant> will set
> <structfield>index</structfield>
> +	    to the starting buffer index,

I find "starting buffer index" a bit unclear in this context, as we don't 
create any buffer.

> and it will check the validity of
> +	    <structfield>memory</structfield> and
> <structfield>format.type</structfield>.
> +	    If those are invalid -1 is returned and errno is set to &EINVAL;,
> +	    otherwise <constant>VIDIOC_CREATE_BUFS</constant> returns 0. It will
> +	    never set errno to &EBUSY; in this particular case.</entry>
>  	  </row>
>  	  <row>
>  	    <entry>__u32</entry>
-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux