Hi, Guennadi Got it! Thank you! We will update our client driver. Thanks Albert Wang 86-21-61092656 -----Original Message----- From: Guennadi Liakhovetski [mailto:g.liakhovetski@xxxxxx] Sent: Monday, 04 June, 2012 23:49 To: Albert Wang Cc: linux-media@xxxxxxxxxxxxxxx Subject: RE: [PATCH] [media] soc-camera: Correct icl platform data assignment On Mon, 4 Jun 2012, Albert Wang wrote: > Hi, Guennadi > > Yes, maybe you are right. > I checked some i2c client drivers, they all changed it to: > > struct soc_camera_link *icl = soc_camera_i2c_to_link(client); > > We also can update our client driver, but could you please explain why > do you change it? Since you have already found the change, you could also use git blame to find this commit: commit b569a3766136e710883a16a91cd12942560e772b Author: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> Date: Wed Sep 21 20:16:30 2011 +0200 V4L: soc-camera: start removing struct soc_camera_device from client drivers Remove most trivial uses of struct soc_camera_device from most client drivers, abstracting some of them inside inline functions. Next steps will eliminate remaining uses and modify inline functions to not use struct soc_camera_device. I.e., client drivers should become independent of soc-camera, that's why they shoudn't access struct soc_camera_device. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
