Hi Hans, Thanks for your review (I'm a bit amazed at how fast you went through the code :). I'll address your excellent comments soon. I'm still unsure about a numbre of things. Two of them: 1. It seems to mee tracing is not too nice and I wasn't really sure how to handle it: dev_xxx, pr_xxx, v4l2_xxx. What's the current trend? 2. The original driver allowed to set frame size, but it seemed to me that could be done at userspace. Hence, my implementation says: V4L2_STD_625_50 is 720x756 and V4L2_STD_525_60 is 720x480. (This is related to the way the video decoder saa711x also assuming that sizes.) So userspace is supposed to get frame size, right after changing video standard and handle buffer of appropriate size. What do you think? On Sat, May 26, 2012 at 2:50 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > (Ezequiel, your original CC list was mangled, so I'm reposting this) > Sorry about this :( I'll check my git-send-mail config. Thanks again, Ezequiel. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
