Re: [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sylwester,

On 26 May 2012 14:09, Sylwester Nawrocki <snjw23@xxxxxxxxx> wrote:
> Hi Sachin,
>
>
> On 05/25/2012 07:38 PM, Sachin Kamat wrote:
>>
>> Fixes the following sparse warning:
>> drivers/media/video/s5p-fimc/fimc-lite-reg.c:218:6: warning: symbol
>> 'flite_hw_set_out_order' was not declared. Should it be static?
>
>
> Thanks for the patches. However I'm inclined to squash this whole
> series into one patch, since it addresses same issue in one driver,
> just in different. I don't see a good reason to split those changes
> like this. Could you make it just one patch instead ?

Sure. I will send it on Monday.
In fact I too wanted to send it as a single patch but wasn't quite
sure if it was OK to do so.

>
>
> Regards,
> Sylwester



-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux