Hi Andrzej! Thanks for the patch, but I do have two questions: On Tue 22 May 2012 17:33:53 Andrzej Hajda wrote: > Those patches add end of stream handling for s5p-mfc encoder. > > The first patch was sent already to the list as RFC, but the discussion ended > without any decision. > This patch adds new v4l2_buffer flag V4L2_BUF_FLAG_EOS. Below short > description of this change. > > s5p_mfc is a mem-to-mem MPEG/H263/H264 encoder and it requires that the last > incoming frame must be processed differently, it means the information about > the end of the stream driver should receive NOT LATER than the last > V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE buffer. Common practice > of sending empty buffer to indicate end-of-stream do not work in such case. > Setting V4L2_BUF_FLAG_EOS flag for the last V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE > buffer seems to be the most straightforward solution here. > > V4L2_BUF_FLAG_EOS flag should be used by application if driver requires it How will the application know that? > and it should be set only on V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE buffers. Why only for this type? Regards, Hans > > The second patch implements end-of-stream handling in s5p-mfc. > > Comments are welcome > Andrzej Hajda > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
