Re: [PATCH] lg2160: fix off-by-one error in lg216x_write_regs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



eeek!  spelling error in dan's name!  my apologies.  I will correct
this in my tree before I ask Mauro to merge it.

-Mike

On Mon, May 21, 2012 at 11:34 AM, Michael Krufky <mkrufky@xxxxxxxxxxxxxx> wrote:
> Fix an off-by-one error in lg216x_write_regs, causing the last element
> of the lg216x init block to be ignored.  Spotted by Dan Carpenteter.
>
> Thanks-to: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Michael Krufky <mkrufky@xxxxxxxxxxx>
> ---
>  drivers/media/dvb/frontends/lg2160.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb/frontends/lg2160.c b/drivers/media/dvb/frontends/lg2160.c
> index a3ab1a5..cc11260 100644
> --- a/drivers/media/dvb/frontends/lg2160.c
> +++ b/drivers/media/dvb/frontends/lg2160.c
> @@ -126,7 +126,7 @@ static int lg216x_write_regs(struct lg216x_state *state,
>
>        lg_reg("writing %d registers...\n", len);
>
> -       for (i = 0; i < len - 1; i++) {
> +       for (i = 0; i < len; i++) {
>                ret = lg216x_write_reg(state, regs[i].reg, regs[i].val);
>                if (lg_fail(ret))
>                        return ret;
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux