Hi Sakari,
thanks for the patch.
On 05/17/2012 11:15 PM, Sakari Ailus wrote:
> The string "_ACTUAL" does not say anything more about the target names. Drop
> it. V4L2 selection API was changed by "V4L: Rename V4L2_SEL_TGT_[CROP/COMPOSE]_ACTIVE to
> V4L2_SEL_TGT_[CROP/COMPOSE]" by Sylwester Nawrocki. This patch does the same
> for the V4L2 subdev API.
>
> Signed-off-by: Sakari Ailus<sakari.ailus@xxxxxx>
Are these all changes, or do you think we could try to drop the _SUBDEV
part as well from the below selection target names, so they are same
across V4L2 and subdev API ? :-)
I realize it might me quite a bit of documentation work and it's pretty
late for getting these patches in for v3.5.
I still have a dependency on my previous pull request which is pending
for the patch you mentioned. Do you think we should leave "_SUBDEV"
in subdev selection target names for now (/ever) ?
Regards,
Sylwester
> ---
...
> diff --git a/include/linux/v4l2-subdev.h b/include/linux/v4l2-subdev.h
> index 812019e..01eee06 100644
> --- a/include/linux/v4l2-subdev.h
> +++ b/include/linux/v4l2-subdev.h
> @@ -128,11 +128,11 @@ struct v4l2_subdev_frame_interval_enum {
> #define V4L2_SUBDEV_SEL_FLAG_KEEP_CONFIG (1<< 2)
>
> /* active cropping area */
> -#define V4L2_SUBDEV_SEL_TGT_CROP_ACTUAL 0x0000
> +#define V4L2_SUBDEV_SEL_TGT_CROP 0x0000
> /* cropping bounds */
> #define V4L2_SUBDEV_SEL_TGT_CROP_BOUNDS 0x0002
> /* current composing area */
> -#define V4L2_SUBDEV_SEL_TGT_COMPOSE_ACTUAL 0x0100
> +#define V4L2_SUBDEV_SEL_TGT_COMPOSE 0x0100
> /* composing bounds */
> #define V4L2_SUBDEV_SEL_TGT_COMPOSE_BOUNDS 0x0102
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
