On Tue, 15 May 2012 15:35:15 +0200 Gianluca Gennari <gennarone@xxxxxxxxx> wrote: > Il 15/05/2012 15:25, Mauro Carvalho Chehab ha scritto: > > Em 15-05-2012 10:16, Gianluca Gennari escreveu: > >> This patch: > >> http://patchwork.linuxtv.org/patch/10824/ > >> moved the file fixp-arith.h from drivers/input/ to include/linux/ . > >> > >> To make this file available to old kernels, we must include it in the > >> media_build package. > >> > >> The version included here comes from kernel 3.4-rc7. > >> > >> This patch corrects the following build error: > >> > >> media_build/v4l/ov534.c:38:30: error: linux/fixp-arith.h: No such file or directory > >> media_build/v4l/ov534.c: In function 'sethue': > >> media_build/v4l/ov534.c:1000: error: implicit declaration of function 'fixp_sin' > >> media_build/v4l/ov534.c:1001: error: implicit declaration of function 'fixp_cos' > >> > >> Tested on kernel 2.6.32-41-generic-pae (Ubuntu 10.04). > >> > >> Signed-off-by: Gianluca Gennari <gennarone@xxxxxxxxx > >> --- > >> linux/include/linux/fixp-arith.h | 87 ++++++++++++++++++++++++++++++++++++++ > > > > It is not that simple, as make clean will remove it. > > > > I can think on a few possible solutions for it: > > 1) just don't compile ov534 on older kernels; > > 2) add a backport patch that will dynamically create it; > > 3) add linux/include/linux/fixp-arith.h inside the tarball with: > > TARFILES += include/linux/fixp-arith.h > > > > Eventually, you can also tweak with the building system, but it doesn't sound a good > > idea to keep this header there as-is for kernels > 3.4, as some changes on this header > > can be added there. > > > >>From all above, (3) is the simpler one. I'll apply it. > > [...] > > > It looks like this file has not been changed in the last years, so > chances are it will not change in the future. So adding it in the > tarball file looks as a good solution. > Hi, I just wanted to mention that it has been proposed to move part of include/linux/fixp-arith.h to a .c file (maybe under lib/) in order to share some code between the users, which are now 2 (drivers/input/ff-memless.c and drivers/media/video/gspca/ov534.c). I don't know yet if I'll do it or when it will be done but the file _might_ change not too far in the future. Regards, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?
Attachment:
pgpuWJGOfjcwC.pgp
Description: PGP signature
