Re: [PATCH 1/3] stv090x: Fix typo in register macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andreas,

Sorry about the late reply.

Which datasheet revision are you using ? I looked at RevG and found that the
register ERRCNT22 @ 0xF59D, 0xF39D do have bitfields by name Px_ERR_CNT2
on Page 227.

Did you overlook that by some chance ?

Best Regards,
Manu


On Tue, Feb 28, 2012 at 2:12 AM, Andreas Regel <andreas.regel@xxxxxx> wrote:
> Fix typo in register macros of ERRCNT2.
>
> Signed-off-by: Andreas Regel <andreas.regel@xxxxxx>
> ---
>  drivers/media/dvb/frontends/stv090x.c     |    2 +-
>  drivers/media/dvb/frontends/stv090x_reg.h |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/dvb/frontends/stv090x.c
> b/drivers/media/dvb/frontends/stv090x.c
> index 4aef187..6c3c095 100644
> --- a/drivers/media/dvb/frontends/stv090x.c
> +++ b/drivers/media/dvb/frontends/stv090x.c
> @@ -3526,7 +3526,7 @@ static int stv090x_read_per(struct dvb_frontend *fe,
> u32 *per)
>        } else {
>                /* Counter 2 */
>                reg = STV090x_READ_DEMOD(state, ERRCNT22);
> -               h = STV090x_GETFIELD_Px(reg, ERR_CNT2_FIELD);
> +               h = STV090x_GETFIELD_Px(reg, ERR_CNT22_FIELD);
>                reg = STV090x_READ_DEMOD(state, ERRCNT21);
>                m = STV090x_GETFIELD_Px(reg, ERR_CNT21_FIELD);
> diff --git a/drivers/media/dvb/frontends/stv090x_reg.h
> b/drivers/media/dvb/frontends/stv090x_reg.h
> index 93741ee..26c8885 100644
> --- a/drivers/media/dvb/frontends/stv090x_reg.h
> +++ b/drivers/media/dvb/frontends/stv090x_reg.h
> @@ -2232,8 +2232,8 @@
>  #define STV090x_P2_ERRCNT22
>  STV090x_Px_ERRCNT22(2)
>  #define STV090x_OFFST_Px_ERRCNT2_OLDVALUE_FIELD                7
>  #define STV090x_WIDTH_Px_ERRCNT2_OLDVALUE_FIELD                1
> -#define STV090x_OFFST_Px_ERR_CNT2_FIELD                        0
> -#define STV090x_WIDTH_Px_ERR_CNT2_FIELD                        7
> +#define STV090x_OFFST_Px_ERR_CNT22_FIELD               0
> +#define STV090x_WIDTH_Px_ERR_CNT22_FIELD               7
>  #define STV090x_Px_ERRCNT21(__x)                      (0xF59E - (__x - 1) *
> 0x200)
>  #define STV090x_P1_ERRCNT21
>  STV090x_Px_ERRCNT21(1)
> --
> 1.7.2.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux