On 12.05.2012 21:08, Thomas Mair wrote:
Changes compared to version 0.2:
- removed reading of signal strength for tuners FC0012,FC0013 (is now supported by fc0012,fc0013 driver)
- moved definition of register names to rtl2832_priv.h
- cleaned up demod private structure
- replaced rtl2832_log2 function with intlog2 from dvb_math
Signed-off-by: Thomas Mair<thomas.mair86@xxxxxxxxxxxxxx>
Testing shows UCB counter is totally broken. It does that all the time,
64 => <some number> => 64
status SCVYL | signal 2b2b | snr b08c | ber 00000024 | unc 00000064 |
FE_HAS_LOCK
status SCVYL | signal 2b2b | snr a7b8 | ber 0000007d | unc 0000005e |
FE_HAS_LOCK
status SCVYL | signal 2b2b | snr b08c | ber 0000002c | unc 00000064 |
FE_HAS_LOCK
Also other small issue. You have added new line to the log writings
provided by DVB USB. DVB USB log writing has already new line! That is
2nd time I point out line errors. Did you use some special set-up during
the development ?
May 13 21:33:06 localhost kernel: [204738.354039] rtl28xxu:
rtl2832u_frontend_attach: FC0012 tuner found
May 13 21:33:06 localhost kernel: [204738.354040]
May 13 21:33:06 localhost kernel: [204738.361304] DVB: registering
adapter 0 frontend 0 (Realtek RTL2832 (DVB-T))...
I quickly looked patches through and those looked very good. I will try
to review those tonight.
And here is whole set (tuner+rtl2832u) if someone else would like to test:
http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/rtl2832u
regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html