On 13.05.2012 18:24, Oliver Schinagl wrote:
Hi antti,
I've just updated my local branch of your experimental branch and got
some conflicts because you moved the header inclusions from the C file
to the header file. Why is that? I thought it was really bad practice to
have includes in header files.
http://git.linuxtv.org/anttip/media_tree.git/commitdiff/7d28d8226cffd1ad6e555b36f6f9855d8bba8645
Because "struct state" was inside af9013.h and I added "struct
af9033_config" to state. Due to that af9033_config visibility I was
forced to move af9013.h include to the af9015.h and moved all the others
too.
What is problem you has met?
DVB USB driver header file is something like private place for data
other than code as it is not included by any other driver.
regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
