Re: [PATCH] V4L: soc-camera: (cosmetic) use a more explicit name for a host handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 08 May 2012 19:44:11 Guennadi Liakhovetski wrote:
> On Tue, 8 May 2012, Aguirre, Sergio wrote:
> > On Tue, May 8, 2012 at 12:00 PM, Guennadi Liakhovetski wrote:
> > > Use "enum_framesizes" instead of "enum_fsizes" to more precisely follow
> > > the name of the respective ioctl().
> > > 
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> > 
> > Looks good to me!
> 
> Thanks
> 
> > I'll redo my patch following this ioctl name matching.
> 
> Well, but naming was just one doubt about your patch - and in fact the
> least important one. What about the other one - the actually important one
> - do we really want to abuse struct v4l2_frmivalenum, or we want to switch
> to the one, used for pad operations or we want to invent something new? We
> still haven't got any opinions on that...

What about switching to pad operations altogether ? :-)


-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux