Hi Sakari,
On 05/06/2012 12:12 PM, Sakari Ailus wrote:
Hi Sylwester,
Sylwester Nawrocki wrote:
This patch adds v4l2_ctrl_new_std_int_menu() helper function which can
be used in drivers for creating standard integer menu control. It is
similar to v4l2_ctrl_new_std_menu(), except it doesn't have a mask
parameter and an additional qmenu parameter allows passing an array
of signed 64-bit integers constituting the menu items.
It would make sense to have the mask and no pointer to the menu items if
the menu items are universally the same. This could come into question
on some standards, for example. For example, we currently have bit rates
in controls but they are strings, not integers. I could imagine we will
have such menus in the future.
I'd suggest to rename v4l2_ctrl_new_std_int_menu() as
v4l2_ctrl_new_int_menu(), as opposed to the former which would use
standardised items in the menu --- to be implemented when needed.
Thank you for pointing it out. Let me just correct this and resend
the patch.
Best regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
