On Mon, 30 Apr 2012 15:51:01 +0200 Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx> wrote: > On Mon, 23 Apr 2012 14:16:25 -0600 > Jonathan Corbet <corbet@xxxxxxx> wrote: > > > On Mon, 23 Apr 2012 15:21:04 +0200 > > Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx> wrote: > > > > > Jonathan, maybe fixp_sin() and fixp_cos() can be used in > > > drivers/media/video/ov7670.c too where currently ov7670_sine() and > > > ov7670_cosine() are defined, but I didn't want to send a patch I could > > > not test. > > > > Seems like a good idea. No reason to have multiple such hacks in the > > kernel; I'll look at dumping the ov7670 version when I get a chance. That > > may not be all that soon, though; life is a bit challenging at the moment. > > > > One concern is that if we're going to add users to fixp-arith.h, some of > > it should maybe go to a C file. Otherwise we'll create duplicated copies > > of the cos_table array for each user. I'm not sure the functions need to > > be inline either; nobody expects cos() to be blindingly fast. > > > > Jonathan, does lib/fixp-arith.c sound OK to you? I'll put that on my > TODO, unless Johann wans to do some more rework; in any case I think we > can still merge this patchset like it is right now. > > Jean-Francois will you take care of that? > Or wait :) I'll send a v2, I think I should merge the current COLORS control used for SENSOR_OV767x and the SATURATION one I added for SENSOR_OV772x as they both are V4L2_CID_SATURATION. Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?
Attachment:
pgpNqrBGrdwXc.pgp
Description: PGP signature
